Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebranding UI new landing page #8207

Merged
merged 45 commits into from
Jan 15, 2025
Merged

Rebranding UI new landing page #8207

merged 45 commits into from
Jan 15, 2025

Conversation

hasparus
Copy link
Collaborator

@hasparus hasparus commented Dec 30, 2024 •
edited
Loading

Description

I've put together the new website.

We can merge #8181 to make the diff smaller here.

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/compose-cli 1.3.5-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/apollo-link 0.105.12-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/cli 0.98.17-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/config 0.106.17-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/http 0.105.12-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/migrate-config-cli 1.4.9-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎
@graphql-mesh/urql-exchange 0.105.12-alpha-20250104194027-99cc051cc98e42e9cf2f39493f9193a17ac72b6c npm ↗︎ unpkg ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://1c13d706.graphql-mesh.pages.dev

@hasparus hasparus requested a review from dimaMachina January 2, 2025 10:45
dimaMachina
dimaMachina reviewed Jan 2, 2025
View reviewed changes
website/src/pages/_app.tsx
Comment on lines +9 to +10
{ path: '../fonts/PPNeueMontreal-Regular.woff2', weight: '400' },
{ path: '../fonts/PPNeueMontreal-Medium.woff2', weight: '500' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about if we move fonts as static assets in guild-components? if you need help with it ping me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely can do it, but these will still need to be relative paths. I tried to move the whole next/font machinery once, and turns out the way Next is handling it doesn't allow that.

@hasparus hasparus force-pushed the rebranding-ui-new-landing-page branch from ac1090a to c71c53d Compare January 4, 2025 19:33
@hasparus
Copy link
Collaborator Author

hasparus commented Jan 6, 2025

This section should also have less mx? image

Why? It's even with the content of the previous section.

image

@hasparus hasparus mentioned this pull request Jan 9, 2025
Closed
1 task
@kamilkisiela
Copy link
Collaborator

There's a weird dark border, but I suspect it's a scrollbar

Screenshot 2025-01-10 at 09 36 54

@kamilkisiela
Copy link
Collaborator

I'm using dark mode in Chrome (and macos), but it's kind of weird to see a scrollbar that has a dark background on a light website.

Screenshot 2025-01-10 at 09 39 25

@kamilkisiela
Copy link
Collaborator

Maybe we could highlight those most important deployment targets?

Screenshot 2025-01-10 at 09 37 15

Like this:

Screenshot 2025-01-10 at 09 38 47

@ardatan ardatan force-pushed the master branch 2 times, most recently from c85f182 to cfefa10 Compare January 10, 2025 11:18
@hasparus hasparus merged commit 09b0c32 into master Jan 15, 2025
15 checks passed
@hasparus hasparus deleted the rebranding-ui-new-landing-page branch January 15, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@dimaMachina dimaMachina Awaiting requested review from dimaMachina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hasparus @dimaMachina @kamilkisiela @saihaj